[webkit-reviews] review requested: [Bug 79499] [GTK] Add support for nested event loops in RunLoop : [Attachment 129009] Patch Proposal

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 79499: [GTK] Add support for nested event loops in RunLoop
https://bugs.webkit.org/show_bug.cgi?id=79499

Attachment 129009: Patch Proposal
https://bugs.webkit.org/attachment.cgi?id=129009&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=129009&action=review


> Source/WebCore/platform/gtk/RunLoopGtk.cpp:72
> +    GDK_THREADS_ENTER();
> +    g_main_loop_run(nestedMainLoop);
> +    GDK_THREADS_LEAVE();

I don't think we should add this here. Note that RunLoop might be used to
create run loops on any thread, that's why there's main() and current() static
methods. So this can be used by a thread that doesn't even use GDK at all. So,
I think the user should decide whether to use GDK_THREADS_ENTER/LEAVE, the UI
process in the case of showModalDialog()