[webkit-reviews] review requested: [Bug 75848] [EFL] Replace malloc/calloc/free to new/delete : [Attachment 129031] Next patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 27 06:47:21 PST 2012


Tomasz Morawski <t.morawski at samsung.com> has asked  for review:
Bug 75848: [EFL] Replace malloc/calloc/free to new/delete
https://bugs.webkit.org/show_bug.cgi?id=75848

Attachment 129031: Next patch
https://bugs.webkit.org/attachment.cgi?id=129031&action=review

------- Additional Comments from Tomasz Morawski <t.morawski at samsung.com>
Fixed Raphael's comments.

Additional change:
I had to left malloc for Ewk_Tile object due to compilation error when "new"
was used:

Source/WebKit/efl/ewk/ewk_tiled_model.cpp:189:16: error: uninitialized const
member in ‘Ewk_Tile {aka struct _Ewk_Tile}’ using ‘new’ without new-initializer
[-fpermissive]
Source/WebKit/efl/ewk/ewk_tiled_backing_store.h:71:22: note: ‘_Ewk_Tile::width’
should be initialized

Anyway, initialization of const fileds in Ewk_Tile looks very ugly. Do you have
any good idea to fix this without use of base C++ features like constructor or
private section?


More information about the webkit-reviews mailing list