[webkit-reviews] review denied: [Bug 79649] Web Inspector: WebKit2: need API to when the Inspector is in the front : [Attachment 128990] Proposed Change

[bugzilla-daemon at webkit.org]

John Sullivan <sullivan at apple.com> has denied Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 79649: Web Inspector: WebKit2: need API to when the Inspector is in the
front
https://bugs.webkit.org/show_bug.cgi?id=79649

Attachment 128990: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=128990&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128990&action=review


> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:126
> +	   [menuItem setTitle:WEB_UI_STRING("Hide Web Inspector", "title for
Hide Web Inspector menu item")];

Don’t you also need to handle the “Show Web Inspector” case here?

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:257
> +    return m_isVisible && [m_inspectorView.get().window isMainWindow];

It would be good to reference a bug number in this FIXME.