[webkit-reviews] review granted: [Bug 78313] Element::removeShadowRoot(), setShadowRoot() should be moved into ShadowTree : [Attachment 128982] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 78313: Element::removeShadowRoot(), setShadowRoot() should be moved into
ShadowTree
https://bugs.webkit.org/show_bug.cgi?id=78313

Attachment 128982: Patch
https://bugs.webkit.org/attachment.cgi?id=128982&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
>Unfortunately removeAllShadowRoots() now requires the element. So what I can
do here is just to call rareData()->m_shadowTree.clear().
>
>Currently our code assumes that a shadow root could be removed from an element
now, and we have tests for it. However, since we should not have such API, we
can remove that assumption. This will reduce the code and make it clear. I
think it should be done in another bug though.

This looks reasonable. When we need the host element, there should be at least
one shadow root.
If there is no shadow root. We won't need the reference the the host.