[webkit-reviews] review denied: [Bug 78313] Element::removeShadowRoot(), setShadowRoot() should be moved into ShadowTree : [Attachment 128976] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 78313: Element::removeShadowRoot(), setShadowRoot() should be moved into
ShadowTree
https://bugs.webkit.org/show_bug.cgi?id=78313

Attachment 128976: Patch
https://bugs.webkit.org/attachment.cgi?id=128976&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128976&action=review


Basically looks good. Could you polish a bit?

> Source/WebCore/ChangeLog:9
> +

Could you mention now ShadowTree is on its own heap?

> Source/WebCore/dom/Element.cpp:125
> +    if (hasShadowRoot())

Can be hasShadowTree()?

> Source/WebCore/dom/Element.cpp:126
> +	   shadowTree()->removeAllShadowRoots();

It looks we can do removeAllShadowRoots() in the ShadowTree dtor then we can
just delete the ShadowTree instance here.