[webkit-reviews] review denied: [Bug 73156] [Microdata] Implement HTMLPropertiesCollection collection.namedItem() : [Attachment 126761] Updated patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Arko Saha
<nghq36 at motorola.com>'s request for review:
Bug 73156: [Microdata] Implement HTMLPropertiesCollection
collection.namedItem()
https://bugs.webkit.org/show_bug.cgi?id=73156

Attachment 126761: Updated patch
https://bugs.webkit.org/attachment.cgi?id=126761&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126761&action=review


> Source/WebCore/ChangeLog:7
> +

Please describe what the patch is doing.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2235
> +    if ($interfaceName eq "HTMLPropertiesCollection") {

Maybe you can remove the hard-coding by using [CustomNamedGetter] (or
[JSCustomNamedGetter]).
https://trac.webkit.org/wiki/WebKitIDL#CustomNamedGetter