[webkit-reviews] review denied: [Bug 79629] Color input type should be clickable through keyboard : [Attachment 128963] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 26 23:36:03 PST 2012


Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 79629: Color input type should be clickable through keyboard
https://bugs.webkit.org/show_bug.cgi?id=79629

Attachment 128963: Patch
https://bugs.webkit.org/attachment.cgi?id=128963&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128963&action=review


> Source/WebCore/ChangeLog:8
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * CMakeLists.txt: Added BaseClickableWithKeyInputType.cpp

Please summarize the code change.
e.g. Introduce BaseClickableWithKeyInputType, and ColorInputType inherits it
because ....

> Source/WebCore/html/BaseClickableWithKeyInputType.cpp:3
> + * Copyright (C) 2012 Google Inc. All rights reserved.
> + *

This file contains the code of BaseButtonInpuType.cpp.	You have to respect the
copyright notice of the original BaseButtonInputType.cpp.


More information about the webkit-reviews mailing list