[webkit-reviews] review denied: [Bug 79628] Add a ChromiumGpuAndroid port. : [Attachment 128962] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Hao Zheng <zhenghao at chromium.org>'s
request for review:
Bug 79628: Add a ChromiumGpuAndroid port.
https://bugs.webkit.org/show_bug.cgi?id=79628

Attachment 128962: Patch
https://bugs.webkit.org/attachment.cgi?id=128962&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128962&action=review


> Tools/Scripts/webkitpy/layout_tests/port/factory.py:76
> -	       return 'chromium-linux'
> +	       if os.environ.get('GYP_DEFINES', '').find('OS=android') >= 0:
> +		   return 'chromium-android'
> +	       else:
> +		   return 'chromium-linux'

This part of the change is wrong.  If you want to create the the
chromium-android port, you need to pass it on the command line:

--platform=chromium-android

> Tools/Scripts/webkitpy/layout_tests/port/factory.py:100
> -	       port_name = port_name + '-' + self._host.platform.os_name
> +	       if os.environ.get('GYP_DEFINES', '').find('OS=android') >= 0:
> +		   port_name = 'chromium-gpu-android'
> +	       else:
> +		   port_name = port_name + '-' + self._host.platform.os_name

Same here.