[webkit-reviews] review canceled: [Bug 79274] Fix <msubsup> formatting, especially for a tall base, subscript, or superscript : [Attachment 128924] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 26 21:44:26 PST 2012


Julien Chaffraix <jchaffraix at webkit.org> has canceled Dave Barton
<dbarton at mathscribe.com>'s request for review:
Bug 79274: Fix <msubsup> formatting, especially for a tall base, subscript, or
superscript
https://bugs.webkit.org/show_bug.cgi?id=79274

Attachment 128924: Patch
https://bugs.webkit.org/attachment.cgi?id=128924&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128924&action=review


I think the test failure is a flake. The patch looks good to me, just a couple
of tweaks and it is ready to get in.

> Source/WebCore/ChangeLog:3
> +	   Fix <msubsup> formatting

You missed the bug title change in your ChangeLog's update.

> Source/WebCore/ChangeLog:12
> +	   Test: 6 existing test files in mathml/presentation now produce
improved results,

Nit: for posterity, you could copy the improvements you mentioned in the bug
here.

> Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp:152
> +    // FIXME: Julien Chaffraix suggests that we add some way to check or
ASSERT() that subscript and
> +    // superscript are what we think they are, not some :before or :after
content or other (future?)
> +    // possibility.

Don't need to mention me (though I like the thought :)). We usually don't
mention people in FIXMEs: people change, FIXME usually don't. Here it could be:


// FIXME: We should ASSERT that |subscript| and |superscript| are really the
renderers we want (for example generated content could change our hierarchy and
confuse us).


More information about the webkit-reviews mailing list