[webkit-reviews] review denied: [Bug 78473] ShadowRoot needs innerHTML : [Attachment 128662] Updated Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 26 20:45:27 PST 2012
MORITA Hajime <morrita at google.com> has denied review:
Bug 78473: ShadowRoot needs innerHTML
https://bugs.webkit.org/show_bug.cgi?id=78473
Attachment 128662: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=128662&action=review
------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128662&action=review
Tried this again. And found that this doesn't work.
Please test this using debug build so that you can see the assertion failure.
> Source/WebCore/dom/ShadowRoot.cpp:154
> + RefPtr<DocumentFragment> fragment = createFragmentFromSource(markup,
toElement(this), ec);
You cannot use toElement() here.
More information about the webkit-reviews
mailing list