[webkit-reviews] review denied: [Bug 79191] [JSC] The end atom of the marked block should be considered to decide if the cell is live : [Attachment 128150] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 26 19:58:00 PST 2012


Filip Pizlo <fpizlo at apple.com> has denied hojong.han at samsung.com's request for
review:
Bug 79191: [JSC] The end atom of the marked block should be considered to
decide if the cell is live
https://bugs.webkit.org/show_bug.cgi?id=79191

Attachment 128150: Patch
https://bugs.webkit.org/attachment.cgi?id=128150&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
This feels strange.  Either it is possible, due to the conservative nature of
the stack scans, that we will see a pointer that passes the not-cell-middle
test but is nonetheless beyond m_endAtom, or it isn't.	If it is, this patch
will make us crash in debug mode and do the right thing in release mode.  If it
is not possible, then this patch just adds noise.

So which is it?  Can you justify why you've added code that results in
assertion failures for the case that you're claiming to handle?


More information about the webkit-reviews mailing list