[webkit-reviews] review granted: [Bug 79612] Encapsulate uses of WKSI to setup a remote layer into a new RemoteLayerClient class : [Attachment 128938] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 26 18:45:12 PST 2012


Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 79612: Encapsulate uses of WKSI to setup a remote layer into a new
RemoteLayerClient class
https://bugs.webkit.org/show_bug.cgi?id=79612

Attachment 128938: Patch
https://bugs.webkit.org/attachment.cgi?id=128938&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128938&action=review


> Source/WebKit2/Platform/mac/RemoteLayerClient.h:45
> +class RemoteLayerClient : public RefCounted<RemoteLayerClient> {

I don't think this needs to be refcounted. Just make it noncopyable and use
OwnPtr instead of RefPtr.


More information about the webkit-reviews mailing list