[webkit-reviews] review requested: [Bug 79608] Getting the instruction stream for a code block should not require two loads : [Attachment 128929] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 26 14:25:44 PST 2012
Filip Pizlo <fpizlo at apple.com> has asked for review:
Bug 79608: Getting the instruction stream for a code block should not require
two loads
https://bugs.webkit.org/show_bug.cgi?id=79608
Attachment 128929: the patch
https://bugs.webkit.org/attachment.cgi?id=128929&action=review
------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
Changed CompactVector(const Vector&) constructor to be explicit, and to use
memcpy.
Tried, and failed, to add static asserts for T being POD. I failed because
JSC::Instruction is not POD according to Clang, but we use it as if it were
POD.
More information about the webkit-reviews
mailing list