[webkit-reviews] review denied: [Bug 79449] Move FILE_SYSTEM code out of WorkerContext and into the fileapi folder : [Attachment 128864] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Ashod Nakashian
<ashodnakashian at yahoo.com>'s request for review:
Bug 79449: Move FILE_SYSTEM code out of WorkerContext and into the fileapi
folder
https://bugs.webkit.org/show_bug.cgi?id=79449

Attachment 128864: Patch
https://bugs.webkit.org/attachment.cgi?id=128864&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128864&action=review


Looks like you're having some trouble building.

> Source/WebCore/fileapi/WorkerContextFileSystem.h:44
> +    void webkitRequestFileSystem(int type, long long size,
PassRefPtr<FileSystemCallback> successCallback, PassRefPtr<ErrorCallback>);
> +    PassRefPtr<DOMFileSystemSync> webkitRequestFileSystemSync(int type, long
long size, ExceptionCode&);
> +    void webkitResolveLocalFileSystemURL(const String& url,
PassRefPtr<EntryCallback> successCallback, PassRefPtr<ErrorCallback>);
> +    PassRefPtr<EntrySync> webkitResolveLocalFileSystemSyncURL(const String&
url, ExceptionCode&);

These all should be static and take a WorkerContext as the first argument.

Also, WorkerContextFileSystem should have a private constructor and destructor,
like DOMWindowFileSystem.

> Source/WebCore/workers/WorkerContext.h:130
> +	   // FIXME: Move these constants to WorkerContextFileSystem.

You should be able to move these now.  We didn't move them right away in the
other patch because of a bug in the code generator that has since been fixed.