[webkit-reviews] review denied: [Bug 79478] LayerTreeHostProxy uses Functional instead of MessageQueue for accumulating tasks. : [Attachment 128853] patch v.4

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 79478: LayerTreeHostProxy uses Functional instead of MessageQueue for
accumulating tasks.
https://bugs.webkit.org/show_bug.cgi?id=79478

Attachment 128853: patch v.4
https://bugs.webkit.org/attachment.cgi?id=128853&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128853&action=review


Awesome!
Some touch ups and we're good.

> Source/WebKit2/ChangeLog:8
> +	   It is succinct to collect tasks using Functional because of reducing
codes about
> +	   boilerplate message definition.

Please reword changelog (just an English touch-up):
Use Functional instead of a MessageQueue for messages to the LayerTreeHostProxy
renderer. This makes a lot of the broilerplate code for message-passing
unnecessary, and results in a much more succinct implementation.

> Source/WebKit2/UIProcess/LayerTreeHostProxy.h:92
> +    Vector<Function<void()> > m_functionQueue;

m_functionQueue -> m_renderQueue