[webkit-reviews] review requested: [Bug 79518] Web Inspector: Close TabbedPanes on middle click of tab handle : [Attachment 128780] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has asked  for review:
Bug 79518: Web Inspector: Close TabbedPanes on middle click of tab handle
https://bugs.webkit.org/show_bug.cgi?id=79518

Attachment 128780: Patch
https://bugs.webkit.org/attachment.cgi?id=128780&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128780&action=review


> Source/WebCore/inspector/front-end/TabbedPane.js:619
> +	       if (event.button == 1 ||
event.target.classList.contains('tabbed-pane-header-tab-close-button'))

Quotes are used instead of apostrophes for string literals across Web
Inspector.
Also, to determine if a CSS class is present on an element, you should use
event.target.hasStyleClass("tabbed-pane-header-tab-close-button"); for better
readability (Element.prototype.hasStyleClass is defined in utilities.js).