[webkit-reviews] review granted: [Bug 78937] Implement static compression curve parameters for DynamicsCompressorNode : [Attachment 128832] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 78937: Implement static compression curve parameters for
DynamicsCompressorNode
https://bugs.webkit.org/show_bug.cgi?id=78937

Attachment 128832: Patch
https://bugs.webkit.org/attachment.cgi?id=128832&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128832&action=review


This looks fine per your walking through the algorithm with me offline. A
couple of minor nits. r=me

> Source/WebCore/platform/audio/DynamicsCompressor.cpp:58
> +    if (parameterID < ParamLast)

Is this worth an ASSERT?

> Source/WebCore/platform/audio/DynamicsCompressorKernel.cpp:174
> +	   k = sqrt(minK * maxK);

sqrtf?

> Source/WebCore/webaudio/DynamicsCompressorNode.idl:33
> +	   readonly attribute AudioParam reduction; // in Decibels

I assume these changes are being specified?