[webkit-reviews] review granted: [Bug 79375] Supplemental interfaces are not disabled with the "Conditional" attribute : [Attachment 128763] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 79375: Supplemental interfaces are not disabled with the "Conditional"
attribute
https://bugs.webkit.org/show_bug.cgi?id=79375

Attachment 128763: Patch
https://bugs.webkit.org/attachment.cgi?id=128763&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128763&action=review


Please just re-upload a patch after rebasing your patch with the latest WebKit
trunk. Let me cq+ it after seeing green faces of ews-bots.

>>> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:-1018
>>> -	     }
>> 
>> Is it OK to remove this part?
> 
> I think so, since it was ifdeffing the inside of the function it needed to
provide an empty return value for functions that declared one. Now the whole
function is ifdeffed so the problem goes away.

Thanks for the clarification.