[webkit-reviews] review granted: [Bug 77646] [chromium] Plumb animation started notifications from CCLayerTreeHost to GraphicsLayerChromium : [Attachment 128811] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted vollick at chromium.org's request
for review:
Bug 77646: [chromium] Plumb animation started notifications from
CCLayerTreeHost to GraphicsLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=77646

Attachment 128811: Patch
https://bugs.webkit.org/attachment.cgi?id=128811&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
I think there's an issue with startTime here - on the impl side we're using the
monotonicallyIncreasingTime() clock, but GraphicsLayerClient is expecting the
currentTime() timebase.  I think we need a re-normalization pass on the time
values somewhere (probably GraphicsLayerChromium) in case the timebases are
different for the two time sources.  As we discussed offline I think it's fine
to file a bug on that issue separately and take care of it before we turn this
on by default since it'll be pretty isolated from the rest of this patch, which
looks great.

R=me!