[webkit-reviews] review canceled: [Bug 78412] CSS 2.1 failure: fixed-table-layout-006 fails : [Attachment 126630] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has canceled Robert Hogan (absent
23/02 to 13/03) <robert at webkit.org>'s request for review:
Bug 78412: CSS 2.1 failure: fixed-table-layout-006 fails
https://bugs.webkit.org/show_bug.cgi?id=78412

Attachment 126630: Patch
https://bugs.webkit.org/attachment.cgi?id=126630&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126630&action=review


> Source/WebCore/rendering/FixedTableLayout.cpp:160
> +		       w.setValue(w.value() +
cell->borderAndPaddingLogicalWidth());

I don't think this is the right change. On some code path, you may end up
accounting for borders and paddings twice (!!!).

Doing some archaeology, it looks like you should just revert
https://bugs.webkit.org/show_bug.cgi?id=8126 that mentioned that borders and
paddings should not go into column's width (if I am reading your CL correctly).
This doesn't match CSS 3 anymore:
http://www.w3.org/TR/2002/WD-css3-border-20021107/#the-border-shorthands
http://www.w3.org/TR/css3-box/#the-padding