[webkit-reviews] review granted: [Bug 79151] Implement limited parsing of -webkit-grid-column and -webkit-grid-row : [Attachment 128786] Rebaselined XCode file.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 24 14:14:31 PST 2012


Ojan Vafai <ojan at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 79151: Implement limited parsing of -webkit-grid-column and
-webkit-grid-row
https://bugs.webkit.org/show_bug.cgi?id=79151

Attachment 128786: Rebaselined XCode file.
https://bugs.webkit.org/attachment.cgi?id=128786&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128786&action=review


Please merge the JS file into the html test before committing.

> LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html:26
> +<script src="resources/grid-item-column-row-get-set.js"></script>

I'd rather you inline the JS here. Having multiple files for a test is a pain.


More information about the webkit-reviews mailing list