[webkit-reviews] review granted: [Bug 79368] Update TextTrackCue API : [Attachment 128800] Updated patch.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 79368: Update TextTrackCue API
https://bugs.webkit.org/show_bug.cgi?id=79368

Attachment 128800: Updated patch.
https://bugs.webkit.org/attachment.cgi?id=128800&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128800&action=review


I feel a bit under-informed on this effort, so I fear I'm just picking at nits.
 I'm comfortable rubber-stamping this change though, I trust your awareness of
the spec.

> Source/WebCore/html/track/TextTrackCue.cpp:423
> +	       if (writingDirection == verticalKeywordOLD())

We've historically used deprecated() for this sort of thing, but it's not clear
(to me at least) what the proper replacement function is.  Will we always have
these OLD() functions around?