[webkit-reviews] review denied: [Bug 76677] AXPress event coordinates are always sent as (0, 0) : [Attachment 128771] Fixed style patch.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied
samuel_white at apple.com's request for review:
Bug 76677: AXPress event coordinates are always sent as (0, 0)
https://bugs.webkit.org/show_bug.cgi?id=76677

Attachment 128771: Fixed style patch.
https://bugs.webkit.org/attachment.cgi?id=128771&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128771&action=review


> Source/WebCore/dom/MouseEvent.cpp:184
> +	   int clientX = rect.location().x() + rect.size().width() / 2;
> +	   int clientY = rect.location().y() + rect.size().height() / 2;

absoluteBoundingBoxRect is document-relative. clientX and clientY should be
viewport-relative, given their names.

This will break in subframes, CSS-transformed subframes, and scrolled
documents. All these cases should be tested.

> Source/WebCore/dom/MouseEvent.cpp:186
> +	   m_screenLocation = IntPoint(clientX + domWindow->screenX(), clientY
+ domWindow->screenY());

I don't think that's a good way to convert to screen coordinates.

It would be best to use the methods on Widget.h to convert to the containing
window. Not sure how best to go from there to the screen.

> LayoutTests/ChangeLog:6
> +	   Make sure AXPress events target an elements center point.

element's

>
LayoutTests/platform/mac/accessibility/press-event-has-target-coordinates.html:
8
> +<button id="button" style="height:30px; width:60px;">Submit</button>

It would be nice to test with a CSS-transformed element too.