[webkit-reviews] review granted: [Bug 79421] Need a WK1 Mac API to filter which subframes go into WebArchives as they are created : [Attachment 128631] Patch v2 - Use a block

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 79421: Need a WK1 Mac API to filter which subframes go into WebArchives as
they are created
https://bugs.webkit.org/show_bug.cgi?id=79421

Attachment 128631: Patch v2 - Use a block
https://bugs.webkit.org/attachment.cgi?id=128631&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128631&action=review


Feel free to add an API test as well.

> Source/WebKit/mac/DOM/WebDOMOperations.mm:89
> +class WebFrameFilter : public WebCore::FrameFilter {
> +public:
> +    WebFrameFilter(ShouldIncludeSubframeInWebArchiveBlock filterBlock);
> +	   
> +private:
> +    virtual bool shouldIncludeSubframe(Frame*) const OVERRIDE;
> +
> +    ShouldIncludeSubframeInWebArchiveBlock m_filterBlock;
> +};

Though perhaps not strictly necessary due to the one place it is used, it seems
safer to Block_copy/Block_release this in the c++ class.