[webkit-reviews] review granted: [Bug 79486] [Qt] API: Unify the loading properties and signals. : [Attachment 128725] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 79486: [Qt] API: Unify the loading properties and signals.
https://bugs.webkit.org/show_bug.cgi?id=79486

Attachment 128725: Patch
https://bugs.webkit.org/attachment.cgi?id=128725&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128725&action=review


r=me.

The only iffy thing that I think can be easily fixed if it actually turns out
to be a problem (I'm not sure it is), is that the argument to the
loadingChanged signal is very short-lived. This isn't quite specific to this
patch, but perhaps we should consider using actual JavaScript objects as
parameters (QJSValue) with according properties. (or JSON if you want so :)

> Source/WebKit2/UIProcess/API/qt/qwebloadrequest_p.h:47
> +    QWebLoadRequestPrivate* d;

As a general rule perhaps we should consider adopting the Qt rule of using
QScopedPointer for the d-pointer.