[webkit-reviews] review canceled: [Bug 32410] [Qt] Allow to use WebCore image decoders : [Attachment 128697] proposed patch - the change will not affect on other ports

[bugzilla-daemon at webkit.org]

Zoltan Horvath <zoltan at webkit.org> has canceled Zoltan Horvath
<zoltan at webkit.org>'s request for review:
Bug 32410: [Qt] Allow to use WebCore image decoders
https://bugs.webkit.org/show_bug.cgi?id=32410

Attachment 128697: proposed patch - the change will not affect on other ports
https://bugs.webkit.org/attachment.cgi?id=128697&action=review

------- Additional Comments from Zoltan Horvath <zoltan at webkit.org>
(In reply to comment #31)
> (From update of attachment 128697 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=128697&action=review
> 
> >> Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:109
> >> +void error_exit(j_common_ptr cinfo) NO_RETURN;
> > 
> > error_exit is incorrectly named. Don't use underscores in your identifier
names.	[readability/naming] [4]
> 
> Did you intend to remove the NO_RETURN in this branch perhaps?

Ups. Sorry. I removed it.