[webkit-reviews] review requested: [Bug 32410] [Qt] Allow to use WebCore image decoders : [Attachment 128697] proposed patch - the change will not affect on other ports

[bugzilla-daemon at webkit.org]

Zoltan Horvath <zoltan at webkit.org> has asked  for review:
Bug 32410: [Qt] Allow to use WebCore image decoders
https://bugs.webkit.org/show_bug.cgi?id=32410

Attachment 128697: proposed patch - the change will not affect on other ports
https://bugs.webkit.org/attachment.cgi?id=128697&action=review

------- Additional Comments from Zoltan Horvath <zoltan at webkit.org>
(In reply to comment #23)
> > Source/WebCore/WebCore.pri:214
> > +	 LIBS += -ljpeg -lpng12
> 
> It would be nice to replace the direct linkage with qmake config tests that
print out a message or abort. That can be done in a follow-up patch of course
:)

Okay. I prefer to make it in a separate patch.

(In reply to comment #26)
> Rolled out in http://trac.webkit.org/changeset/108692

Thank you!

I put extra guards into the change to not break other ports.