[webkit-reviews] review denied: [Bug 78980] SVG error parsing empty path : [Attachment 128506] ProposedPatch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Joe Thomas
<joethomas at motorola.com>'s request for review:
Bug 78980: SVG error parsing empty path
https://bugs.webkit.org/show_bug.cgi?id=78980

Attachment 128506: ProposedPatch
https://bugs.webkit.org/attachment.cgi?id=128506&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Hi Joe, thanks for the patch! Phillip is right, that this is rather a
work-around than a fix.
If we want to treat an empty path as valid,
SVGPathParserFactor::buildXXXFromString() needs to be fixed.
There are various ways to convert a SVGPathByteStream to a String, and/or a
SVGPathSegList - I guess you'd need to inspect all these code paths, to make
sure we deal with empty paths correctly.

Also your change lacks test coverage, where this actually affects a test,
despite the error printing which is now gone.
Can you investigate more?