[webkit-reviews] review granted: [Bug 79442] Move Worker-related APIs from DOMWindow.idl to DOMWindowWorker.idl : [Attachment 128650] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 23 23:03:04 PST 2012


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 79442: Move Worker-related APIs from DOMWindow.idl to DOMWindowWorker.idl
https://bugs.webkit.org/show_bug.cgi?id=79442

Attachment 128650: Patch
https://bugs.webkit.org/attachment.cgi?id=128650&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128650&action=review


> Source/WebCore/workers/DOMWindowWorker.idl:31
> +#if defined(ENABLE_WORKERS) && ENABLE_WORKERS
> +	   attribute WorkerConstructor Worker; // Usable with the new operator
> +#endif
> +
> +#if defined(ENABLE_SHARED_WORKERS) && ENABLE_SHARED_WORKERS
> +	   attribute [JSCustomGetter, V8EnabledAtRuntime]
SharedWorkerConstructor SharedWorker; // Usable with the new operator
> +#endif

Can we use Conditional here?  It's prettier.


More information about the webkit-reviews mailing list