[webkit-reviews] review canceled: [Bug 79237] [EFL][DRT] Implement setValueForUser and setAutofilled : [Attachment 128208] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 23 20:32:39 PST 2012


MORITA Hajime <morrita at google.com> has canceled  review:
Bug 79237: [EFL][DRT] Implement setValueForUser and setAutofilled
https://bugs.webkit.org/show_bug.cgi?id=79237

Attachment 128208: proposed patch
https://bugs.webkit.org/attachment.cgi?id=128208&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
(In reply to comment #5)
> (In reply to comment #4)
> > Point here is that you cannot implement auto-complete feature for your
browser with EFL API.
> > You'll need such an API and DRT should demonstrate it.
> 
> DumpRenderTreeSupport is actually a private part of the EFL API that predates
WebCore.internals and fulfills much the same purpose. GTK+, Qt, and EFL use it
to add private API for the DRT.

Hmm interesting. In general I understand DumpRenderTree serves such purposes.
But for this case, is it making sense to make the test pass even if the port
doesn't support the feature?

Clearing r- since I realized that I don't have enough understanding of the
background context.


More information about the webkit-reviews mailing list