[webkit-reviews] review granted: [Bug 79212] [BlackBerry] Upstream ImageBlackBerry in platform/graphics/blackberry : [Attachment 128375] updated patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Robin Cao
<robin.cao at torchmobile.com.cn>'s request for review:
Bug 79212: [BlackBerry] Upstream ImageBlackBerry in
platform/graphics/blackberry
https://bugs.webkit.org/show_bug.cgi?id=79212

Attachment 128375: updated patch
https://bugs.webkit.org/attachment.cgi?id=128375&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128375&action=review


>>> Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp:52
>>> +	     context->fillRect(FloatRect(-1, -7, 2, 14));
>> 
>> some magic numbers here. Anyway we could improve it?
> 
> We just want to draw a "x" here. Maybe i should add a comment?

please add.

>>> Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp:70
>>> +	 img->setData(buffer.release(), true);
>> 
>> what is true here?
> 
> true == allDataReceived
> bool Image::setData(PassRefPtr<SharedBuffer> data, bool allDataReceived);

lets add a /*allDataReceived*/ comment