[webkit-reviews] review granted: [Bug 78878] Adding a ShadowRoot to image-backed element causes a crash : [Attachment 128615] Fixing windows build break

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 78878: Adding a ShadowRoot to image-backed element causes a crash
https://bugs.webkit.org/show_bug.cgi?id=78878

Attachment 128615: Fixing windows build break
https://bugs.webkit.org/attachment.cgi?id=128615&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128615&action=review


> Source/WebCore/rendering/RenderBlock.cpp:5831
> +	       && !(firstLetterBlock->isDeprecatedFlexibleBox()
> +		    &&
static_cast<RenderDeprecatedFlexibleBox*>(firstLetterBlock)->buttonText());

whoa, this is so specific and hard to understand. Perhaps a static inline
helper with a descriptive name should go here?