[webkit-reviews] review denied: [Bug 79421] Need a WK1 Mac API to filter which subframes go into WebArchives as they are created : [Attachment 128606] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 23 17:51:12 PST 2012


Sam Weinig <sam at webkit.org> has denied Brady Eidson <beidson at apple.com>'s
request for review:
Bug 79421: Need a WK1 Mac API to filter which subframes go into WebArchives as
they are created
https://bugs.webkit.org/show_bug.cgi?id=79421

Attachment 128606: Patch v1
https://bugs.webkit.org/attachment.cgi?id=128606&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128606&action=review


> Source/WebKit/mac/DOM/WebDOMOperationsPrivate.h:53
> + at interface DOMNode (WebDOMNodeOperationsPrivate)
> +- (WebArchive
*)webArchiveWithWebArchiveCreationDelegate:(id)webArchiveCreationDelegate;
> + at end

This should take a block, not an arbitrary object.


More information about the webkit-reviews mailing list