[webkit-reviews] review denied: [Bug 78473] ShadowRoot needs innerHTML : [Attachment 128447] Updated Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 23 17:42:16 PST 2012


MORITA Hajime <morrita at google.com> has denied Kaustubh Atrawalkar
<kaustubh at motorola.com>'s request for review:
Bug 78473: ShadowRoot needs innerHTML
https://bugs.webkit.org/show_bug.cgi?id=78473

Attachment 128447: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=128447&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
Almost looks good! 

Could you add another test case which ensures that setting a HTML fragment not
only results
a innerHTML value change, but also actually creates DOM nodes?
we can test it even without (currently broken) getElementId() or something.
querySelector() or just traversing the tree by firstChild etc. will be
sufficient.


More information about the webkit-reviews mailing list