[webkit-reviews] review denied: [Bug 79375] Supplemental interfaces are not disabled with the "Conditional" attribute : [Attachment 128611] Patch for the bug

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 79375: Supplemental interfaces are not disabled with the "Conditional"
attribute
https://bugs.webkit.org/show_bug.cgi?id=79375

Attachment 128611: Patch for the bug
https://bugs.webkit.org/attachment.cgi?id=128611&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128611&action=review


Thanks for working on the patch!

> Source/WebCore/ChangeLog:19
> +	   * bindings/scripts/CodeGeneratorCPP.pm:
> +	   (GenerateHeader):
> +	   * bindings/scripts/CodeGeneratorJS.pm:
> +	   (GenerateHeader):
> +	   * bindings/scripts/CodeGeneratorObjC.pm:
> +	   (GenerateHeader):
> +	   * bindings/scripts/CodeGeneratorV8.pm:
> +	   (GenerateHeader):

Also we need to make similar changes in CodeGeneratorGObject.pm.

> Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm:497
> +	       my $conditionalString =
GenerateConditionalString($function->signature);

Maybe you need to support the conditional block for attributes in CPP?

> Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm:923
> +	       my $functionConditionalString =
GenerateConditionalString($function->signature);

Maybe you need to support the conditional block for attributes in ObjC?