[webkit-reviews] review granted: [Bug 79397] XSS Auditor targeting legitimate frames as false positives. : [Attachment 128580] Patch + some refactoring.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 23 16:08:22 PST 2012
Adam Barth <abarth at webkit.org> has granted Thomas Sepez <tsepez at chromium.org>'s
request for review:
Bug 79397: XSS Auditor targeting legitimate frames as false positives.
https://bugs.webkit.org/show_bug.cgi?id=79397
Attachment 128580: Patch + some refactoring.
https://bugs.webkit.org/attachment.cgi?id=128580&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128580&action=review
This looks great.
> Source/WebCore/html/parser/XSSAuditor.cpp:316
> + if (isContainedInRequest(m_cachedDecodedSnippet) &&
isContainedInRequest(decodedSnippetForJavascript(token))) {
Javascript => JavaScript
More information about the webkit-reviews
mailing list