[webkit-reviews] review granted: [Bug 79239] [Chromium] video-referer.html fails : [Attachment 128545] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 23 14:36:16 PST 2012


Eric Carlson <eric.carlson at apple.com> has granted Dale Curtis
<dalecurtis at chromium.org>'s request for review:
Bug 79239: [Chromium] video-referer.html fails
https://bugs.webkit.org/show_bug.cgi?id=79239

Attachment 128545: Patch
https://bugs.webkit.org/attachment.cgi?id=128545&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128545&action=review


These changes do fix a problem with the test, but neither your ChangeLog nor
your explanations in this bug fully explain why. It is much easier to review a
proposed fix when a full explanation is presented.

> LayoutTests/ChangeLog:6
> +	   Fix event setup race by moving setup into body onload() handler.

Please say something more specific.


More information about the webkit-reviews mailing list