[webkit-reviews] review granted: [Bug 79310] DFG OSR exit value profiling should have graceful handling of local variables and arguments : [Attachment 128411] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 23 14:32:39 PST 2012


Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 79310: DFG OSR exit value profiling should have graceful handling of local
variables and arguments
https://bugs.webkit.org/show_bug.cgi?id=79310

Attachment 128411: the patch
https://bugs.webkit.org/attachment.cgi?id=128411&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128411&action=review


> Source/JavaScriptCore/bytecode/LazyOperandValueProfile.h:162
> +    OwnPtr<SegmentedVector<LazyOperandValueProfile, 8> > m_data;

typedef for SegmentedVector<LazyOperandValueProfile, 8> wouldn't hurt.

> Source/JavaScriptCore/dfg/DFGNode.h:488
> +    

Please revert before landing.


More information about the webkit-reviews mailing list