[webkit-reviews] review denied: [Bug 75903] matchMedia() MediaQueryList not updating : [Attachment 128393] patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Luiz Agostini <luiz at webkit.org>'s
request for review:
Bug 75903: matchMedia() MediaQueryList not updating
https://bugs.webkit.org/show_bug.cgi?id=75903

Attachment 128393: patch
https://bugs.webkit.org/attachment.cgi?id=128393&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=128393&action=review


> Source/WebCore/page/FrameView.cpp:973
> -	   // Viewport-dependent media queries may cause us to need completely
different style information.
> -	   // Check that here.
> -	   if (document->styleSelector()->affectedByViewportChange()) {
> -	       document->styleSelectorChanged(RecalcStyleImmediately);
> -	       InspectorInstrumentation::mediaQueryResultChanged(document);
> -	   }
> +	   document->styleSelectorChanged(RecalcStyleImmediately,
Document::ViewportChangeReason);

Instead of adding a flag to an existing function, you should add a new one that
handles viewport changes and calls to styleSelectorChanged() if needed.
Document::evaluateViewportDependentMediaQueries() or similar.