[webkit-reviews] review granted: [Bug 79321] [chromium] Clean up GraphicsContext3D initialization paths : [Attachment 128378] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 23 13:03:54 PST 2012
Kenneth Russell <kbr at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 79321: [chromium] Clean up GraphicsContext3D initialization paths
https://bugs.webkit.org/show_bug.cgi?id=79321
Attachment 128378: Patch
https://bugs.webkit.org/attachment.cgi?id=128378&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128378&action=review
Looks good. r=me
> Source/WebKit/chromium/ChangeLog:21
> + 2) GraphicsContext3DPrivate::createGraphicsContextFromWebContext()
wraps the WebGraphicsContext3D in a
Missing end of comment?
> Source/WebKit/chromium/src/GraphicsContext3DPrivate.h:58
> + // via ContextLost before using the context in any way.. Once made
current on a thread, the context cannot
Two periods after "way".
More information about the webkit-reviews
mailing list