[webkit-reviews] review granted: [Bug 77229] [chromium] Implement keyframed animations for the cc thread. : [Attachment 128495] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted vollick at chromium.org's request
for review:
Bug 77229: [chromium] Implement keyframed animations for the cc thread.
https://bugs.webkit.org/show_bug.cgi?id=77229

Attachment 128495: Patch
https://bugs.webkit.org/attachment.cgi?id=128495&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128495&action=review


Looks great R=me.  A few naming nits to address before landing, just to stay
consistent.

> Source/WebCore/platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:48
> +    CCTransformKeyframe(double time)

nit: explicit

>
Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationController.cpp:40
> +template <typename KEYFRAME, typename VALUE>

style nit (here and elsewhere): we reserve ALLCAPS style for macros in WebKit
and typically just use normal type names for template parameters. So this would
be "Keyframe" and "Value"