[webkit-reviews] review granted: [Bug 79328] [Qt] Build fix. macro "QSKIP" takes 1 arguments on Qt5, but takes 2 on Qt4. : [Attachment 128512] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 23 12:24:25 PST 2012


Csaba Osztrogonac <ossy at webkit.org> has granted Holger Freyther
<zecke at selfish.org>'s request for review:
Bug 79328: [Qt] Build fix. macro "QSKIP" takes 1 arguments on Qt5, but takes 2
on Qt4.
https://bugs.webkit.org/show_bug.cgi?id=79328

Attachment 128512: Patch
https://bugs.webkit.org/attachment.cgi?id=128512&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
r=me. Just a quick question: Won't it break the build with previous version of
Qt5?
If yes, then I'll land it with updating Qt5 on the bots tomorrow morning.


More information about the webkit-reviews mailing list