[webkit-reviews] review granted: [Bug 74380] [BlackBerry] Upstream BlackBerry API web page related files : [Attachment 128516] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Jacky Jiang
<zkjiang008 at gmail.com>'s request for review:
Bug 74380: [BlackBerry] Upstream BlackBerry API web page related files
https://bugs.webkit.org/show_bug.cgi?id=74380

Attachment 128516: Patch
https://bugs.webkit.org/attachment.cgi?id=128516&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128516&action=review


> Source/WebKit/blackberry/Api/WebPage.cpp:4156
> +    ASSERT(layer);
> +
> +    if (layer->parent())

follow up: remove blank line

> Source/WebKit/blackberry/Api/WebPage.cpp:4207
> +    RenderLayer* layer = renderer->enclosingLayer();
> +
> +    do {

ditto.

> Source/WebKit/blackberry/Api/WebPage.cpp:4233
> +	   }
> +
> +    } while (layer = parentLayer(layer));

ditto

> Source/WebKit/blackberry/Api/WebPage.cpp:4541
> +Platform::IntRect WebPage::focusNodeRect()
> +{
> +    return d->focusNodeRect();
> +}

lets also move it to Private in a followup