[webkit-reviews] review denied: [Bug 78940] [chromium] Don't assume contents texture exists. : [Attachment 128370] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 23 11:40:47 PST 2012


James Robinson <jamesr at chromium.org> has denied Eric Penner
<epenner at chromium.org>'s request for review:
Bug 78940: [chromium] Don't assume contents texture exists.
https://bugs.webkit.org/show_bug.cgi?id=78940

Attachment 128370: Patch
https://bugs.webkit.org/attachment.cgi?id=128370&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
This feels like it's at the wrong level - we know at sync time whether our mask
layer has a texture or not so I feel that should just set a bit then and there.


If we don't have the mask texture, do we want to bother rendering the element
at all?  I don't think that makes a lot of sense - we should either show the
content with the mask or not at all, we shouldn't show something incorrect.


More information about the webkit-reviews mailing list