[webkit-reviews] review granted: [Bug 78638] Don't clear IntentRequest callback pointers on stop() : [Attachment 128012] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 23 11:39:20 PST 2012
Adam Barth <abarth at webkit.org> has granted Greg Billock <gbillock at google.com>'s
request for review:
Bug 78638: Don't clear IntentRequest callback pointers on stop()
https://bugs.webkit.org/show_bug.cgi?id=78638
Attachment 128012: Patch
https://bugs.webkit.org/attachment.cgi?id=128012&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128012&action=review
> Tools/DumpRenderTree/chromium/WebViewHost.h:239
> + virtual void dispatchIntent(WebKit::WebFrame* source, const
WebKit::WebIntentRequest&) OVERRIDE;
We actually don't use OVERRIDE in for the WebKit API to make it easier to
change. That's mostly a concern for cross-repository OVERRIDE declarations
though.
More information about the webkit-reviews
mailing list