[webkit-reviews] review granted: [Bug 79345] [CMake] Add FindQuickTimeSDK : [Attachment 128498] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 23 10:40:07 PST 2012


Adam Roben (:aroben) <aroben at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 79345: [CMake] Add FindQuickTimeSDK
https://bugs.webkit.org/show_bug.cgi?id=79345

Attachment 128498: Patch
https://bugs.webkit.org/attachment.cgi?id=128498&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128498&action=review


> Source/cmake/FindQuickTimeSDK.cmake:10
> +    "C:/Program Files (x86)/QuickTime SDK/CIncludes"
> +    "C:/Program Files/QuickTime SDK/CIncludes"

Should we use $ENV{PROGRAMFILES} and $ENV{PROGRAMFILES(X86)} here?


More information about the webkit-reviews mailing list