[webkit-reviews] review granted: [Bug 79344] [CMake] Add FindDirectX : [Attachment 128492] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 79344: [CMake] Add FindDirectX
https://bugs.webkit.org/show_bug.cgi?id=79344

Attachment 128492: Patch
https://bugs.webkit.org/attachment.cgi?id=128492&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128492&action=review


> Source/cmake/FindDirectX.cmake:12
> +    "C:/Program Files (x86)/Microsoft DirectX SDK*/Include"
> +    "C:/Program Files/Microsoft DirectX SDK*/Include"

Should we use $ENV{PROGRAMFILES} and $ENV{PROGRAMFILES(X86)} here? Hard-coding
"C:" doesn't seem so great.