[webkit-reviews] review granted: [Bug 79336] [Chromium] Add HarfBuzzShaperBase class : [Attachment 128414] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 79336: [Chromium] Add HarfBuzzShaperBase class
https://bugs.webkit.org/show_bug.cgi?id=79336

Attachment 128414: Patch
https://bugs.webkit.org/attachment.cgi?id=128414&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128414&action=review


> Source/WebCore/WebCore.gypi:3472
> +	       'platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp',
> +	       'platform/graphics/harfbuzz/HarfBuzzShaperBase.h',

Can you also include the cpp file in PlatformBlackBerry.cmake?

>
Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:303

> +	   if (static_cast<unsigned>(logClustersIndex) < m_item.item.length &&
isWordEnd(m_item.item.pos + logClustersIndex))

Should logClustersIndex be unsigned or size_t?	That might remove some of the
casts.