[webkit-reviews] review denied: [Bug 79143] [Texmap] Consolidate the common parts of TextureMapperGL::drawTexture : [Attachment 128368] Patch.

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Yael
<yael.aharon at nokia.com>'s request for review:
Bug 79143: [Texmap] Consolidate the common parts of
TextureMapperGL::drawTexture
https://bugs.webkit.org/show_bug.cgi?id=79143

Attachment 128368: Patch.
https://bugs.webkit.org/attachment.cgi?id=128368&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128368&action=review


> Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:214
> +    glUniformMatrix4fv(m_matrixVariable, 1, GL_FALSE, m4);
> +    glUniformMatrix4fv(m_sourceMatrixVariable, 1, GL_FALSE, m4src);
> +    glUniform1i(m_sourceTextureVariable, 0);

Doesn't make sense that this part is here and not in the common function.
Let's have prepare() just receive opacity/mask.

> Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:217
> +    if (maskTexture && maskTexture->isValid()) {

Early return

> Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.h:55
> +    virtual void prepareToDraw(const GLfloat m4[], const GLfloat m4src[],
float opacity, const BitmapTexture*) {}

Make it just prepare(opacity, mask)