[webkit-reviews] review granted: [Bug 75602] [JSC] Short circuit for a 16 bit pattern character and an 8 bit string failed : [Attachment 128449] Patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted hojong.han at samsung.com's request
for review:
Bug 75602: [JSC] Short circuit for a 16 bit pattern character and an 8 bit
string failed
https://bugs.webkit.org/show_bug.cgi?id=75602

Attachment 128449: Patch
https://bugs.webkit.org/attachment.cgi?id=128449&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128449&action=review


r+

> Source/JavaScriptCore/yarr/YarrJIT.cpp:819
> +	   if (!((ch > 0xff) && (m_charSize == Char8))) {

Please add a comment similar to what was removed.

> Source/JavaScriptCore/yarr/YarrJIT.cpp:879
> +	       JumpList nonGreedyFailures;

Add a comment here as well.